Skip to content

Get-SqlDscServerPermission: Check for both login and role#2131

Merged
johlju merged 43 commits intodsccommunity:mainfrom
johlju:fix/get-sqldscserverpermission
Sep 5, 2025
Merged

Get-SqlDscServerPermission: Check for both login and role#2131
johlju merged 43 commits intodsccommunity:mainfrom
johlju:fix/get-sqldscserverpermission

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Aug 12, 2025

Pull Request (PR) description

  • Get-SqlDscServerPermission
    • Enhanced the command to support server roles in addition to logins by utilizing
      Test-SqlDscIsRole alongside the existing Test-SqlDscIsLogin check.
    • The function now accepts both login principals and server role principals
      as the Name parameter.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get-SqlDscServerPermission: Should be able to return permissions for a server role

2 participants